RFR: 8332528: Generate code in SwitchBootstraps.generateTypeSwitch that require fewer adaptations [v4]

Jan Lahoda jlahoda at openjdk.org
Thu May 23 11:44:08 UTC 2024


On Thu, 23 May 2024 11:09:14 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> We can fold the call to `Objects.checkIndex` into the code generated in generateTypeSwitchSkeleton instead of doing so by filtering the MH argument. This loads 9 less classes (of which 8 generated LFs and Species classes) on a minimal test, while being neutral on a throughput sanity test:
>> 
>> 
>> Name                   Cnt  Base   Error   Test   Error  Unit  Change
>> SwitchSanity.switchSum  15 8,162 ± 0,117  8,152 ± 0,131 ns/op   1,00x (p = 0,800 )
>>   * = significant
>>   ```
>> 
>> A few additional optimizations includes moving some seldom used `findStatic` calls to a holder. All in all this means a reduction by 22M cycles to bootstrap a trivial switch expression on my M1.
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused import, revert left-overs in MethodTypeDescImpl

Looks good, thanks!

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19307#pullrequestreview-2073701019


More information about the core-libs-dev mailing list