RFR: 8320448: Accelerate IndexOf using AVX2 [v33]

Vladimir Kozlov kvn at openjdk.org
Fri May 24 18:40:12 UTC 2024


On Fri, 24 May 2024 15:33:46 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> Thanks for checking. Well I know that the `MacroAssembler::movdqu(XMMRegister dst, AddressLiteral src, Register rscratch)` method actually generates rip-relative addresses. Maybe we could copy some of that code.
>
> Changed to `lea` with `InternalAddress()`.  Generates the exact same code, but makes more sense.  I looked at `movdqu` and see no code that generates RIP-relative loads.  It merely checks `reachable()` and adds an intermediate `lea` if not reachable.  @djelinski can you clarify please?

I think HotSpot prefer to have full addresses in `lea` for possible patching.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1613874603


More information about the core-libs-dev mailing list