RFR: 8320448: Accelerate IndexOf using AVX2 [v40]
Scott Gibbons
sgibbons at openjdk.org
Fri May 24 23:11:15 UTC 2024
On Fri, 24 May 2024 22:26:56 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments.
>
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 1122:
>
>> 1120: // eq_mask - The bit mask returned that holds the result of the comparison
>> 1121: // rTmp - a temporary register
>> 1122: // rTmp2 - a temporary register
>
> There is no rtmp, rtmp2 here.
Fixed.
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 1129:
>
>> 1127: // _masm - Current MacroAssembler instance pointer
>> 1128: //
>> 1129: // If (n - k) < 32, need to handle reading past end of haystack
>
> Don't see (n-k) < 32 being handled in this function.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1614116033
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1614116814
More information about the core-libs-dev
mailing list