RFR: 8332614: Type-checked ConstantPool.entryByIndex and ClassReader.readEntryOrNull [v3]

Chen Liang liach at openjdk.org
Fri May 24 23:22:16 UTC 2024


> I propose to add type-checked ConstantPool.entryByIndex and ClassReader.readEntryOrNull taking an extra Class parameter, which throws ConstantPoolException instead of ClassCastException on type mismatch, which can happen to malformed ClassFiles.
> 
> Requesting a review from @asotona. Thanks!
> 
> Proposal on mailing list: https://mail.openjdk.org/pipermail/classfile-api-dev/2024-May/000512.html

Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jdk into feature/entry-by-type
 - Merge branch 'master' of https://github.com/openjdk/jdk into feature/entry-by-type
 - Use constants, beautify code
 - 8332614: Type-checked ConstantPool.entryByIndex and ClassReader.readEntryOrNull

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19330/files
  - new: https://git.openjdk.org/jdk/pull/19330/files/c9f6fc18..a68519d3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19330&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19330&range=01-02

  Stats: 15592 lines in 362 files changed: 10436 ins; 3396 del; 1760 mod
  Patch: https://git.openjdk.org/jdk/pull/19330.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19330/head:pull/19330

PR: https://git.openjdk.org/jdk/pull/19330


More information about the core-libs-dev mailing list