RFR: 8331876: JFR: Move file read and write events to java.base [v7]

Alan Bateman alanb at openjdk.org
Tue May 28 13:43:03 UTC 2024


On Tue, 28 May 2024 12:27:46 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of a change that moves the jdk.FileRead and jdk.FileWrite events to java.base to remove the use of the ASM instrumentation.
>> 
>> Testing: jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reduce clutter

I think this looks okay for now and great to see the instrumentation going away.

Follow-on work for the future will be to re-examine the issue with the plan read of the flag (which seems to have previously existed) and to see if we reduce this down to one test rather than two.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19129#pullrequestreview-2082828370


More information about the core-libs-dev mailing list