RFR: 8320448: Accelerate IndexOf using AVX2 [v43]

Scott Gibbons sgibbons at openjdk.org
Tue May 28 21:20:15 UTC 2024


On Tue, 28 May 2024 16:37:23 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix tests
>
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 488:
> 
>> 486:   __ cmpq(r11, nMinusK);
>> 487:   __ ja_b(L_return);
>> 488:   __ movq(rax, r11);
> 
> At places where we know that return value in r11 is correct, we dont need to checkRange so this could have its own label.

Disabling causes the test to succeed, so we're not finding matches beyond the end of the string, correct?  Are we confident that this test passing can warrant removing the range check? @sviswa7 ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1617901070


More information about the core-libs-dev mailing list