RFR: 8320448: Accelerate IndexOf using AVX2 [v49]
Emanuel Peter
epeter at openjdk.org
Thu May 30 16:23:34 UTC 2024
On Thu, 30 May 2024 16:16:59 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:
>> I agree with @eme64 to postpone the integration after JDK 23 is forked in one week. It is not about how you confident with code. It is size of code. I did only limited (tier1-4) testing in our infra which did not cover all our testing configuration.
>
> @vnkozlov OK. I'll defer to you all. I've contacted the author of the fuzzer to see what I can do to set up a local instance. Would this be sufficient to increase confidence for future submissions? We can run it perpetually on fixes (provided I can set it up). Had I done that, we could have had 6 months of fuzzing on top of our tests. Would that have alleviated this concern?
@asgibbons I generally just stop pushing ANY RFE's a week or two before the fork. Even if you did run the fuzzer with it - there are often last-minute changes. And your code here is rather large, so even if you are confident, there must be at least one bug hiding.
Running the fuzzer is nice as pre-integration, but it mostly only catches things post-integration.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16753#issuecomment-2140136262
More information about the core-libs-dev
mailing list