RFR: 8333303: Issues with DottedVersion class

Alexey Semenyuk asemenyuk at openjdk.org
Thu May 30 20:18:11 UTC 2024


- Get rid of DottedVersion#greedy field.
 - Add support to save the unrecognizable remainder of the version string (required to handle Wix4 version string).
 - Implement DottedVersion#equals().
 - add DottedVersion#compareComponents(DottedVersion, DottedVersion) that compares recognized components of the given DottedVersion instances.
 - remove DottedVersion#compareTo(String)

[Edit](https://bugs.openjdk.org/secure/EditComment!default.jspa?id=5130726&commentId=14677610)
[Delete](https://bugs.openjdk.org/secure/DeleteComment!default.jspa?id=5130726&commentId=14677610)

-------------

Commit messages:
 - DottedVersion#compareTo() has been replaced with DottedVersion#compareComponents()
 - DottedVersion refactored. Old parsing code used "==" to test equality of two BiInteger objects and it didn't work right. When the bug was fixed app version check on Windows platform stopped working. It required a bit of work to get it working right.

Changes: https://git.openjdk.org/jdk/pull/19488/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19488&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8333303
  Stats: 320 lines in 6 files changed: 195 ins; 58 del; 67 mod
  Patch: https://git.openjdk.org/jdk/pull/19488.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19488/head:pull/19488

PR: https://git.openjdk.org/jdk/pull/19488


More information about the core-libs-dev mailing list