RFR: 8333303: Issues with DottedVersion class
Alexander Matveev
almatvee at openjdk.org
Thu May 30 23:33:01 UTC 2024
On Thu, 30 May 2024 20:10:05 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
> - Get rid of DottedVersion#greedy field.
> - Add support to save the unrecognizable remainder of the version string (required to handle Wix4 version string).
> - Implement DottedVersion#equals().
> - add DottedVersion#compareComponents(DottedVersion, DottedVersion) that compares recognized components of the given DottedVersion instances.
> - remove DottedVersion#compareTo(String)
>
> [Edit](https://bugs.openjdk.org/secure/EditComment!default.jspa?id=5130726&commentId=14677610)
> [Delete](https://bugs.openjdk.org/secure/DeleteComment!default.jspa?id=5130726&commentId=14677610)
Looks good.
-------------
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19488#pullrequestreview-2089507390
More information about the core-libs-dev
mailing list