RFR: 7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails

Lance Andersen lancea at openjdk.org
Fri May 31 15:26:02 UTC 2024


On Fri, 31 May 2024 00:57:18 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which updates a couple of places in the test to use `try-with-resource`?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-7022325 this change should prevent leaking of resources in case there's any failure in the test. The test continues to pass with this change.

Hi Jai,

I think the change is fine.  I might suggest that we take the opportunity to convert this test  to use junit  as part of this PR

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19492#pullrequestreview-2091120545


More information about the core-libs-dev mailing list