RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option [v2]

Alexander Matveev almatvee at openjdk.org
Fri May 31 19:44:02 UTC 2024


On Thu, 30 May 2024 14:21:51 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8332110: jpackage tries to sign added files without the --mac-sign option [v2]
>
> test/jdk/tools/jpackage/macosx/SigningOptionsTest.java line 97:
> 
>> 95:                     new String[]{"--app-content", TEST_DUKE},
>> 96:                     null,
>> 97:                     "\"codesign\" failure is additional content provided via \"--app-content\""},
> 
> Why is this not a `One of the possible reason for "{0}" failure is additional content provided via "--app-content"`?

It was part of old message. Latest test version has latest message: ""codesign" failed and additional application content was supplied via the "--app-content" parameter."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19377#discussion_r1622884704


More information about the core-libs-dev mailing list