RFR: 8343293: Remove the check for <apphome>/jre/lib/libjava.dylib from the launcher's java_md_macosx.m [v2]

Jaikiran Pai jpai at openjdk.org
Fri Nov 1 14:51:49 UTC 2024


> Can I please get a review of this change which cleans up a leftover code from the launcher's java_md_macosx.m file?
> 
> In https://bugs.openjdk.org/browse/JDK-8329862 changes were done in the launcher code to remove checks for  `<apphome>/jre/lib/` when determining the JDK installation root. Those changes were done in the Unix and Windows files and the macosx one got left out, likely due to an oversight.
> 
> The commit in this PR removes that leftover code. No new tests have been added and existing tier1, tier2, tier3 tests continue to pass.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Roger's suggestion - introduce log message to match unix/windows

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21789/files
  - new: https://git.openjdk.org/jdk/pull/21789/files/e125c18e..e09dd1b3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21789&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21789&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21789.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21789/head:pull/21789

PR: https://git.openjdk.org/jdk/pull/21789


More information about the core-libs-dev mailing list