RFR: 8341399: Add since checker tests to the langtools modules
Nizar Benalla
nbenalla at openjdk.org
Fri Nov 1 15:39:29 UTC 2024
On Fri, 1 Nov 2024 15:28:13 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Can I get a review for this patch that adds `@since` checker tests to the following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. The initial test for `java.base` has been integrated in [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051).
>>
>> The jtreg comments are almost the same as the ones for the `java.base` test, only the Bug ID and the module name being passed to the test are different.
>>
>> I've made a small change to `test/jdk/TEST.groups` to include the new tests.
>>
>> Here are the emails [[1](https://mail.openjdk.org/pipermail/jdk-dev/2024-June/009160.html)] [[2](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html)] in `jdk-dev` describing how the tests work and how to run them.
>>
>> TIA
>
> test/jdk/tools/sincechecker/jdk_compiler/CheckSince_jdkCompiler.java line 27:
>
>> 25: * @test
>> 26: * @bug 8341399
>> 27: * @summary Test for `@since` for java.base module
>
> You forgot to change the summaries but remembered to change the `@run` directives. Curious!
Nice catch! I'll update them
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21542#discussion_r1825966738
More information about the core-libs-dev
mailing list