RFR: 8340311: JPackage app-image exe launches multiple exe's in JDK 22+ [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Fri Nov 1 22:09:29 UTC 2024
On Thu, 31 Oct 2024 22:32:33 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> Alexey Semenyuk has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - Better log message
>> - Rework findAppLauncherPID() into findAndKillAppLauncherProcess() that will kill detected running app launcher processes regardless if their number is as expected or not.
>> - A comment added
>> - Fix copyright year
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java line 235:
>
>> 233:
>> 234: public static void killProcess(long pid) {
>> 235: Executor.of("taskkill", "/F", "/PID", Long.toString(pid)).dumpOutput(true).execute();
>
> In case of two processes (parent and child) it will terminate only parent. Based on `taskkill /?` `/T` needs to be specified to terminate child process as well or call it for both processes.
It is sufficient to terminate the parent process only. The child process will be terminated automatically. Automatic app launcher child process termination was implemented in [JDK-8301247](https://bugs.openjdk.org/browse/JDK-8301247)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21726#discussion_r1826336434
More information about the core-libs-dev
mailing list