RFR: 8335991: Implement Simple Source Files and Instance Main Methods (Fourth Preview)

[Jaikiran Pai]

On Wed, 30 Oct 2024 13:01:29 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> This is a partial implementation of JEP 495 - adjustments of the JEP metadata in `PreviewFeature`. There are no language changes associated with this JEP. Changes to the `java.io.IO` class are covered by https://github.com/openjdk/jdk/pull/21693.

This looks OK to me and matches what is stated in the CSR.

src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 72:

> 70:         //---
> 71:         @JEP(number=495, title="Simple Source Files and Instance Main Methods", status="Fourth Preview")
> 72:         IMPLICIT_CLASSES,

Hello Jan, although it's just an internal enum name, do you think we should rename it to be closer to the JEP's title or is it not worth it?

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21787#pullrequestreview-2411231079
PR Review Comment: https://git.openjdk.org/jdk/pull/21787#discussion_r1826544471