RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]

Thomas Stuefe stuefe at openjdk.org
Mon Nov 4 09:44:42 UTC 2024


On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 Port_](https://openjdk.org/jeps/479).
>> 
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port. This port was [deprecated for removal in JDK 21](https://openjdk.org/jeps/449) with the express intent to remove it in a future release.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove superfluous check for 64-bit on Windows in MacroAssembler::call_clobbered_xmm_registers
>  - Remove windows-32-bit code in CompilerConfig::ergo_initialize

This is a very nice reduction in complexity. As I wrote before, removing windows 32-bit removes the need for calling convention definition, so I think we could get rid of JNICALL in addition to anything stdcall/fastcall related.

I had a close look at hotspot os and os_cpu changes, cursory glances at other places, all looked fine.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21744#pullrequestreview-2412592195


More information about the core-libs-dev mailing list