RFR: 8343547: Restore accidentally removed annotations in LambdaForm from ClassFile API port

Adam Sotona asotona at openjdk.org
Mon Nov 4 16:43:33 UTC 2024


On Mon, 4 Nov 2024 15:47:46 GMT, Chen Liang <liach at openjdk.org> wrote:

> These two annotations are found to be lost during the ClassFile API port of LambdaForm generation.  I seem not able to reproduce the master issue in a current build but could reproduce before when the change is first made.  Anyways this restoration is always a right thing, better commit it and further investigate.
> 
> Old Stable on BMH impl class static species field: https://github.com/openjdk/jdk/pull/17108/files#diff-3d6c6bed9cbcb47fe292bdb0c795ab77e56783fdbb144decc6f00857b020c092L612-L615
> 
> Incorrect way to add InjectedProfile annotation: https://github.com/openjdk/jdk/pull/17108/files#diff-3b05b61400e7766115409b3f508d839fb51e450423822252ab2e18543427c764R618

Good catch, thank you!

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21880#pullrequestreview-2413572679


More information about the core-libs-dev mailing list