RFR: 8340205: Native linker allows MemoryLayout consisting of only PaddingLayout [v10]

Jorn Vernee jvernee at openjdk.org
Tue Nov 5 14:20:48 UTC 2024


On Tue, 5 Nov 2024 13:51:13 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add checks of exception messages

test/jdk/java/foreign/TestLinker.java line 188:

> 186:             assertEquals(e.getMessage(),
> 187:                     "The padding layout x2 was preceded by another padding layout x1 in [b1x1x2i4]");
> 188:         }

Doesn't `assertThrows` return the exception instance? (which could be used to check the message as well).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21041#discussion_r1829429545


More information about the core-libs-dev mailing list