RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v30]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Tue Nov 5 14:37:56 UTC 2024
On Tue, 5 Nov 2024 07:51:05 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with five additional commits since the last revision:
>>
>> - Add oopDesc::has_klass_gap() check
>> - Rename waitTimeout/set_waitTimeout accessors
>> - Revert suggestion to ThawBase::new_stack_frame
>> - Improve JFR pinned reason in event
>> - Use freeze_result consistently
>
> src/hotspot/share/jfr/metadata/metadata.xml line 160:
>
>> 158:
>> 159: <Event name="VirtualThreadPinned" category="Java Virtual Machine, Runtime" label="Virtual Thread Pinned" thread="true" stackTrace="true">
>> 160: <Field type="string" name="blockingOperation" label="Blocking operation" />
>
> The label should be "Blocking Operation" with a capital "O".
>
> Labels use headline-style capitalization. See here for more information: https://docs.oracle.com/en/java/javase/21/docs/api/jdk.jfr/jdk/jfr/Label.html
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1829463128
More information about the core-libs-dev
mailing list