RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v30]

Patricio Chilano Mateo pchilanomate at openjdk.org
Wed Nov 6 00:08:17 UTC 2024


On Tue, 5 Nov 2024 14:35:11 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - Add oopDesc::has_klass_gap() check
>>  - Rename waitTimeout/set_waitTimeout accessors
>>  - Revert suggestion to ThawBase::new_stack_frame
>>  - Improve JFR pinned reason in event
>>  - Use freeze_result consistently
>
> src/hotspot/share/runtime/objectMonitor.inline.hpp line 50:
> 
>> 48: inline int64_t ObjectMonitor::owner_from(oop vthread) {
>> 49:   int64_t tid = java_lang_Thread::thread_id(vthread);
>> 50:   assert(tid >= 3 && tid < ThreadIdentifier::current(), "must be reasonable");
> 
> Suggestion:
> 
>   assert(tid >= ThreadIdentifier::initial() && tid < ThreadIdentifier::current(), "must be reasonable");

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1830229529


More information about the core-libs-dev mailing list