RFR: 8329251: Print custom truststore/ keystore name [v9]

Sean Coffey coffeys at openjdk.org
Wed Nov 6 14:29:31 UTC 2024


On Wed, 6 Nov 2024 12:03:56 GMT, Prasadrao Koppula <pkoppula at openjdk.org> wrote:

>> Using SharedSecrets, I attempted to expose FileInputStream::path information. After implementing the fix, I validated the startup performance tests. Observed no consistent pattern of performance drops or gains, can disregard the occasional performance drop observed in 1 or 2 runs.
>
> Prasadrao Koppula has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replaced Paths.get with Path.of

This looks good to me. 

I'd suggest logging a new JBS issue to track removal of the Debug.getInstance("pkcs12") use case and substituting it with getInstance("keystore") code (esp. since pkcs12 is now the default keystore type)

-------------

Marked as reviewed by coffeys (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20414#pullrequestreview-2418430330


More information about the core-libs-dev mailing list