RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v42]

[Severin Gehwolf]

On Fri, 1 Nov 2024 18:03:16 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> I expect that the jmodless tests will first build an image (say `image1`) using jlink `--generate-linkable-runtime` option and then verify `image1/bin/jlink` that links from the run-time image.    I don't see `--generate-linkable-runtime` option is used from jmodless tests.   I looked at `AbstractLinkableRuntimeTest` which provides the support to create linkable runtime image but not obvious to me.   Can you describe the idea of this test framework?
>
>> I expect that the jmodless tests will first build an image (say `image1`) using jlink `--generate-linkable-runtime` option and then verify `image1/bin/jlink` that links from the run-time image. I don't see `--generate-linkable-runtime` option is used from jmodless tests. I looked at `AbstractLinkableRuntimeTest` which provides the support to create linkable runtime image but not obvious to me. Can you describe the idea of this test framework?
> 
> OK.  I see this now (`@requires jlink.runtime.linkable` in all jmodless tests).  I.e. No test for the default JDK build.
> 
> I think this feature needs test verification even for the default JDK build.   One way to do that is to build a test image (say `base-image`) using jlink `--generate-linkable-runtime` option and then verify `base-image/bin/jlink` instead of the JDK.

Thanks for the reviews so far! Especially @mlchung who was tremendously helpful! I very much appreciate the support, Mandy!

I think I've addressed all the comments and hope this will be ready for integration soon. The JEP has been targeted and that leaves about a month for this PR to be integrated. I do hope, though, that we can integrate it a few weeks before RDP1 of JDK 24 so as to avoid the last minute crunch time. I'd be happy to fix any remaining blockers and then follow-up with any needed tasks after initial integration of course.

Therefore, paging @AlanBateman @mlchung @mbreinhold @magicus for their final thoughts. Thank you!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2460054319