RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning
Coleen Phillimore
coleenp at openjdk.org
Wed Nov 6 17:40:01 UTC 2024
On Tue, 22 Oct 2024 02:09:33 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 380:
>>
>>> 378: lea(t2_owner_addr, owner_address);
>>> 379:
>>> 380: // CAS owner (null => current thread id).
>>
>> I think we should be more careful when and where we talk about thread id and lock id respectively. Given that `switchToCarrierThread` switches the thread, but not the lock id. We should probably define and talk about the lock id when it comes to locking, as saying thread id may be incorrect.
>>
>> Then there is also the different thread ids, the OS level one, and the java level one. (But not sure how to reconcile this without causing confusion)
>
> Fixed the comments to refer to _lock_id. Even without the switchToCarrierThread case I think that's the correct thing to do.
yes, we preferred lock_id here which is the same as the Java version of thread id, but not the same as the os thread-id.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1811583503
More information about the core-libs-dev
mailing list