Integrated: 8342647: [macosx] Clean up the NSInvocation based call to NSProcessInfo.operatingSystemVersion
Jaikiran Pai
jpai at openjdk.org
Thu Nov 7 00:55:52 UTC 2024
On Sun, 20 Oct 2024 06:41:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which does a tiny cleanup in the macosx specific code in `java_props_macosx.c`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8342647 the `setOSNameAndVersion` function used to dynamically call `NSProcessInfo.operatingSystemVersion` because that property wasn't (statically) available until macosx 10.10 version. Since that version this property has been available even in the latest macosx versions https://developer.apple.com/documentation/foundation/nsprocessinfo/1410906-operatingsystemversion, so it's now possible to statically reference it in the code.
>
> The change in this PR replaces the use of `NSInvocation` with the static reference to this property. No new tests have been added. Existing tier1, tier2 and tier3 tests with this change have all passed.
This pull request has now been integrated.
Changeset: 9e31e78e
Author: Jaikiran Pai <jpai at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/9e31e78e39a4b573c158ef31af3ab4e9a1e229de
Stats: 43 lines in 1 file changed: 3 ins; 22 del; 18 mod
8342647: [macosx] Clean up the NSInvocation based call to NSProcessInfo.operatingSystemVersion
Reviewed-by: bchristi
-------------
PR: https://git.openjdk.org/jdk/pull/21595
More information about the core-libs-dev
mailing list