RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long)
Galder Zamarreño
galder at openjdk.org
Thu Nov 7 10:20:45 UTC 2024
On Thu, 11 Jul 2024 22:30:45 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
> Overall, looks fine.
>
> So, there will be `inline_min_max`, `inline_fp_min_max`, and `inline_long_min_max` which slightly vary. I'd prefer to see them unified. (Or, at least, enhance `inline_min_max` to cover `minL`/maxL` cases).
>
> Also, it's a bit confusing to see int variants names w/o basic type (`_min`/`_minL` vs `_minI`/`_minL`). Please, clean it up along the way. (FTR I'm also fine handling the renaming as a separate change.)
@iwanowww I applied the changes you suggested. Could you review them?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20098#issuecomment-2461843670
More information about the core-libs-dev
mailing list