RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v8]

[Coleen Phillimore]

On Mon, 4 Nov 2024 23:57:48 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & Linking](https://openjdk.org/jeps/483).
>> 
>> ----
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https://github.com/openjdk/jdk/pull/20517
>> - https://github.com/openjdk/jdk/pull/20843
>> - https://github.com/openjdk/jdk/pull/20958
>> - https://github.com/openjdk/jdk/pull/20959
>> - https://github.com/openjdk/jdk/pull/21049
>> - https://github.com/openjdk/jdk/pull/21143
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @DanHeidinga comment -- exit VM when runtimeSetup() fails

I had a couple of drive by comments.

src/hotspot/share/cds/aotConstantPoolResolver.cpp line 2:

> 1: /*
> 2:  * Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.

If this is a new file, it shouldn't have 2022 in the copyright year.

src/hotspot/share/cds/aotConstantPoolResolver.cpp line 81:

> 79:     }
> 80: 
> 81:     if (!k->is_instance_klass()) {

How can a field, interface or method cp reference point to a non-instance klass?  Or is this for a method in java.lang.Object, which can be an array klass ?  I doubt you should bother to support this special case.

src/hotspot/share/cds/aotConstantPoolResolver.cpp line 138:

> 136:     } else if (elem->is_typeArray_klass()) {
> 137:       return true;
> 138:     } else {

I think bottom_klass can only be InstanceKlass or typeArrayKlass, so else should be not possible and an assert.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21642#pullrequestreview-2420951812
PR Review Comment: https://git.openjdk.org/jdk/pull/21642#discussion_r1832663874
PR Review Comment: https://git.openjdk.org/jdk/pull/21642#discussion_r1832668217
PR Review Comment: https://git.openjdk.org/jdk/pull/21642#discussion_r1832674559