RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v2]

[Patricio Chilano Mateo]

On Thu, 7 Nov 2024 18:32:14 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use JvmtiVTMSTransitionDisabler::VTMS_vthread_mount/unmount
>
> src/hotspot/share/prims/jvmtiThreadState.cpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2003, 2024, Oracle and/or its affiliates. All rights reserved.
> 
> Nit: No need in the copyright update anymore.

Fixed.

> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest/libVThreadEventTest.cpp line 104:
> 
>> 102: 
>> 103:     err = jvmti->GetMethodName(frameInfo[idx].method, &methodName, nullptr, nullptr);
>> 104:     check_jvmti_status(jni, err, "event handler: error in JVMTI GetMethodName call");
> 
> Nit: There is the test library function `get_method_name()` in `jvmti_common.hpp` that can be used here.
> Also, the `methodName` is better to deallocate with the `deallocate() function.
> The same is in the `VirtualThreadMount` callback.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1833226416
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1833225816