RFR: 8337217: Port VirtualMemoryTracker to use VMATree

Johan Sjölen jsjolen at openjdk.org
Fri Nov 8 10:51:52 UTC 2024


On Mon, 14 Oct 2024 10:24:54 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

> > ```c++
> > region->add_committed_region(committed_start, committed_size, ncs); // <-- LOST!
> > ```
> 
> The `region` is not a VMATree::node, it is a `ReservedMemoryRegion*`.

I don't understand what you're trying to say here. Do you see the bug that I'm talking about?

> > Is this part of the code under-tested as we didn't receive a test failure regarding this?
> 
> All JTREG runtime/NMT tests and all tier1 tests have been passed on this code.

Yes, but this code is incorrect. So we should have a test detecting this, but we do not, and so this is under-tested.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20425#issuecomment-2411115944


More information about the core-libs-dev mailing list