RFR: 8337217: Port VirtualMemoryTracker to use VMATree

Afshin Zafari azafari at openjdk.org
Fri Nov 8 10:51:54 UTC 2024


On Mon, 14 Oct 2024 18:56:47 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> I think it's actually the opposite: None of the committed regions will survive after this function.

You maybe missed my point when said " ... some extra committed size in NMT reports". I emphasize on the " the NMT reports", since the committed sizes in this function are added to the global VirtualMemorySummary which is used in reports. 
And yes, no committed regions that added here won't survive after this function.

> This is one of those times when having the ability to create new instances of NMT makes things very nice for testing.

I was talking about the existing tests and why they couldn't catch this bug.(why this is under-tested)

> You simply do something like this (pseudo-code):

Thanks for the pseudo-code, I will implement a test for this specific case. You will see it in one of the future commits here.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20425#issuecomment-2413222662
PR Comment: https://git.openjdk.org/jdk/pull/20425#issuecomment-2413225089
PR Comment: https://git.openjdk.org/jdk/pull/20425#issuecomment-2413227952


More information about the core-libs-dev mailing list