RFR: 8337217: Port VirtualMemoryTracker to use VMATree

Afshin Zafari azafari at openjdk.org
Fri Nov 8 10:52:03 UTC 2024


On Fri, 27 Sep 2024 09:46:27 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/share/nmt/nmtNativeCallStackStorage.hpp line 93:
>> 
>>> 91: 
>>> 92:   const inline NativeCallStack& get(StackIndex si) {
>>> 93:     if (is_invalid(si) || si >= _stacks.length()) {
>> 
>> I don't think this should be here?
>
> Removed.

No, returned back.
This assert is triggered:

#  Internal Error (/home/afshin/scratch/833XX_nmt_VMT_with_tree/src/hotspot/share/utilities/growableArray.hpp:142), pid=1972883, tid=1972931
#  assert(0 <= i && i < _len) failed: illegal index 0 for length 0

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1778358195


More information about the core-libs-dev mailing list