RFR: 8337217: Port VirtualMemoryTracker to use VMATree
Johan Sjölen
jsjolen at openjdk.org
Fri Nov 8 10:52:07 UTC 2024
On Mon, 5 Aug 2024 16:54:40 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> This applies the reserve/commit regardless of outcome, so slightly different.
>
> The main purpose of the `if (...)` cases is to find if the request to apply the delta is valid or not. There are related assertions in VirtualMemory but not so informative. Also, using `log_debug` lets the build proceed and just show the messages.
> These messages help a lot when something goes wrong in terms of commit/uncommit/release failure.
How does my example code not account for this? You can still get rid of the sign checking.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1711187386
More information about the core-libs-dev
mailing list