RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v13]
Saint Wesonga
duke at openjdk.org
Fri Nov 8 17:54:17 UTC 2024
On Wed, 30 Oct 2024 11:05:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> make/scripts/compare.sh line 1457:
>>
>>> 1455: THIS_SEC_BIN="$THIS_SEC_DIR/sec-bin.zip"
>>> 1456: if [ "$OPENJDK_TARGET_OS" = "windows" ]; then
>>> 1457: JGSS_WINDOWS_BIN="jgss-windows-x64-bin.zip"
>>
>> This is now being defined for windows-aarch64 too, when it previously wasn't. That seems wrong,
>> given the "x64" suffix.
>
> Well... this was broken on windows-aarch64 before, too, since then it would have looked for `jgss-windows-i586-bin.zip`.
>
> I'm going to leave this as it is. Obviously there is a lot more work needed to get the compare script running on windows-aarch64, and I seriously doubt anyone care about that platform enough to spend that time (Microsoft themselves seems to have all but abandoned the windows-aarch64 port...).
@magicus @kimbarrett @shipilev Thanks for catching this. We want to get this working on Windows AArch64. I have filed https://bugs.openjdk.org/browse/JDK-8343857.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1834839335
More information about the core-libs-dev
mailing list