RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v6]
Julian Waters
jwaters at openjdk.org
Sat Nov 9 04:26:55 UTC 2024
> After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code as appropriate. I am confident that in many cases this simplistic approach of commenting out code does not fix the underlying issue, and the warning actually found a bug that should be fixed. In these instances, I will be aiming to fix these bugs with help from reviewers, so I recommend anyone reviewing who knows more about the code than I do to see whether there is indeed a bug that needs fixing in a different way than what I did
Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
Copyright in VersionInfo.cpp
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21616/files
- new: https://git.openjdk.org/jdk/pull/21616/files/68767cbe..5e9039fb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21616&range=05
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21616&range=04-05
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/21616.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21616/head:pull/21616
PR: https://git.openjdk.org/jdk/pull/21616
More information about the core-libs-dev
mailing list