RFR: 8342650: Move getChars to DecimalDigits [v4]

Chen Liang liach at openjdk.org
Sun Nov 10 22:54:54 UTC 2024


On Sun, 10 Nov 2024 08:58:18 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to reduce duplication
>> 
>> 1. HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF16
>> 2. Putting these two methods into DecimalDigits can avoid the need to expose them in JavaLangAccess
>> 3. Eliminate duplicate code in BigDecimal
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add benchmark

Looks good. Tier 1-3 tests pass.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21593#pullrequestreview-2425879062


More information about the core-libs-dev mailing list