RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v2]

[Julian Waters]

On Thu, 31 Oct 2024 19:07:42 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>>> I do wonder if mutex support can be implemented for Windows with Acquire/ReleaseSRWLockExclusive. I know it's not strictly needed, but it would be nice to have. Shame threads.h is not available with some Visual Studio versions we support, or at all with gcc. mtx_lock/unlock would be a nice solution to this problem
>> 
>> I'll also start looking into this in the meantime, unless you explicitly want me not to do so
>
>> > I do wonder if mutex support can be implemented for Windows with Acquire/ReleaseSRWLockExclusive. I know it's not strictly needed, but it would be nice to have. Shame threads.h is not available with some Visual Studio versions we support, or at all with gcc. mtx_lock/unlock would be a nice solution to this problem
>> 
>> I'll also start looking into this in the meantime, unless you explicitly want me not to do so
> 
> Feel free to if you'd like to. Personally I don't consider it to be that important.

Bumping, @plummercj I found that casting to void in MUTEX_LOCK and MUTEX_UNLOCK also works, and it seems neater to me. Is this ok with you?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21616#issuecomment-2467690492