RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]

[Alexey Ivanov]

On Fri, 8 Nov 2024 21:01:57 GMT, Phil Race <prr at openjdk.org> wrote:

>>> I'd not looked at this test before but when I do the thing I noticed is that createPrivateValue is no longer used. But I don't see a problem with keeping the rest of the test.
>> 
>> @prrace Do I understand correctly that _“`createPrivateValue` is no longer used”_ means `MultiUIDefaults` is never used with `ProxyLazyValue`?
>> 
>> The [`MultiUIDefaults` class](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/MultiUIDefaults.java) is used in `UIManager`:
>> 
>> https://github.com/openjdk/jdk/blob/c82ad845e101bf5d97c0744377d68002907d4a0e/src/java.desktop/share/classes/javax/swing/UIManager.java#L198
>
>> > I'd not looked at this test before but when I do the thing I noticed is that createPrivateValue is no longer used. But I don't see a problem with keeping the rest of the test.
>> 
>> @prrace Do I understand correctly that _“`createPrivateValue` is no longer used”_ means `MultiUIDefaults` is never used with `ProxyLazyValue`?
>> 
>> The [`MultiUIDefaults` class](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/MultiUIDefaults.java) is used in `UIManager`:
>> 
>> https://github.com/openjdk/jdk/blob/c82ad845e101bf5d97c0744377d68002907d4a0e/src/java.desktop/share/classes/javax/swing/UIManager.java#L198
> 
> I think I was just saying there appeared to be dead code in the test.

> > @prrace Do I understand correctly that _“`createPrivateValue` is no longer used”_ means `MultiUIDefaults` is never used with `ProxyLazyValue`?
>
> I think I was just saying there appeared to be dead code in the test.

Hmm… `createPrivateValue` had been called from the `main` method, so it had been used in the test until it was removed in https://github.com/openjdk/jdk/commit/9eb275c4aaf9a88127c5c33e0bf7ca35125f29ea

Since `MultiUIDefaults` is still used in `UIManager` and we're keeping the test, I'm for keeping a test for `createPrivateValue` too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1837009964