RFR: 8341260: Add Float16 to jdk.incubator.vector [v11]

Raffaello Giulietti rgiulietti at openjdk.org
Tue Nov 12 12:52:21 UTC 2024


On Tue, 12 Nov 2024 05:38:23 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 431:
>> 
>>> 429:      * @see    java.lang.Float#valueOf(String)
>>> 430:      */
>>> 431:     public static Float16 valueOf(String s) throws NumberFormatException {
>> 
>> The current implementation throws when the input is `"NaN"`, with or without an optional sign.
>
> Thanks for catching that; fix and tests added in subsequent push.

Single digit inputs, e.g., `Float16.valueOf"2")` throw as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1838046684


More information about the core-libs-dev mailing list