RFR: 8340133: Add concise usage message to the java executable [v7]
Jan Lahoda
jlahoda at openjdk.org
Tue Nov 12 13:23:09 UTC 2024
On Mon, 11 Nov 2024 14:23:46 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8340133-2
>> - Using correct pplaceholders.
>> - Adjusting text as suggested.
>> - Cleaning up the concise message:
>> - using 2 spaces instead of 4,
>> - rewording the "for more use --help" part of the message as suggested to avoid the word "launcher".
>> - Using lowercase for the keys in the help, using 'source-file' program instead of 'single-file' program.
>> - Using an enum instead of booleans, as suggested.
>> - Adjusting the concise help as suggested: 'using main class of a JAR archive' and '<JarFile>.jar'/'<SourceFile>.java'
>> - Adjusting the concise help based on review suggestions.
>> - Cleanup.
>> - Adjusting/improving the concise help.
>> - ... and 1 more: https://git.openjdk.org/jdk/compare/8eae78c8...b4d7b493
>
> src/java.base/share/classes/sun/launcher/resources/launcher.properties line 241:
>
>> 239: \ -jar <jarfile>.jar to execute the main class of a JAR archive\n\
>> 240: \ -m <module>[/<mainclass>] to execute the main class of a module\n\
>> 241: \ <sourcefile>.java to compile and execute a source-file program\n\n\
>
> I'm not sure about the description of <mainclass>. It uses "compiled class", maybe you meant "compiled main class" or something else to connect it "<mainclass>"?
>
> "-jar <jarfile>.jar" may be confusing because the "java -help" uses "-java <jarfile">". I think the usages need to be the same.
Used `a compiled main class` and `<jarfile>` (without `.jar`) as suggested in:
https://github.com/openjdk/jdk/pull/21411/commits/e9e9ad4bdd0a11244cb1ef84fdeea036e94718c7
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21411#discussion_r1838089070
More information about the core-libs-dev
mailing list