RFR: 8340133: Add concise usage message to the java executable [v7]
Jan Lahoda
jlahoda at openjdk.org
Tue Nov 12 15:36:50 UTC 2024
On Tue, 12 Nov 2024 14:04:07 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> src/java.base/share/classes/sun/launcher/resources/launcher.properties line 241:
>>
>>> 239: \ -jar <jarfile>.jar to execute the main class of a JAR archive\n\
>>> 240: \ -m <module>[/<mainclass>] to execute the main class of a module\n\
>>> 241: \ <sourcefile>.java to compile and execute a source-file program\n\n\
>>
>> I'm not sure about the description of <mainclass>. It uses "compiled class", maybe you meant "compiled main class" or something else to connect it "<mainclass>"?
>>
>> "-jar <jarfile>.jar" may be confusing because the "java -help" uses "-java <jarfile">". I think the usages need to be the same.
>
>> @AlanBateman I'd like to respectfully disagree that this was an improvement. If consistency was the important objection here, maybe it would have been better to update "java -help" to include the .jar?
>
> I assume your disagreement is with Jan's latest update rather than my comment. My comment was just pointing out that it's confusing to use `-jar <jarfile>.jar` in one case and `-jar <jarfile>` in the other.
So, just to double-check: given the request is to make the helps consistent, and dropping the extensions from the concise help is not what was meant, I'll add the extensions both here and to the ordinary help. Correct?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21411#discussion_r1838316368
More information about the core-libs-dev
mailing list