RFR: 8344023: Unnecessary Hashtable usage in LdapClient.defaultBinaryAttrs

Aleksei Efimov aefimov at openjdk.org
Tue Nov 12 16:05:18 UTC 2024


On Tue, 5 Nov 2024 12:49:04 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is fully initialized in `<clinit>` block.
> It means we can replace legacy synchronized `Hashtable` with immutable set.

The changes look good to me. Also, I've launched existing JNDI/LDAP tests, and no issues related to the change were observed.

-------------

Marked as reviewed by aefimov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21903#pullrequestreview-2430030185


More information about the core-libs-dev mailing list