RFR: 8343958: Remove security manager impl in java.lang.Process and java.lang.Runtime.exec [v3]

[Sean Mullan]

On Tue, 12 Nov 2024 18:05:46 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Refactor removing the dependencies on SecurityManager, doPrivileged, and AccessController.
>
> Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 228 commits:
> 
>  - Merge branch 'master' into 8343958-process-sm-cleanup
>  - correct exception message formatting
>  - Simplify the generation of the exception message.
>    The file path is always included in the exception, the IOException cause does not add useful information.
>  - Remove security manager impl in java.lang.Process and java.lang.Runtime.exec
>    Refactor to remove the dependencies on SecurityManager, doPrivileged, and AccessController.
>  - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>  - Merge branch 'master' into jep486
>  - Move remaining JEP 486 failing tests into correct groups.
>  - Move JEP 486 failing tests into hotspot_runtime group.
>  - test/jdk/java/rmi/server/RMIClassLoader/spi/DefaultProperty.java failing
>  - Merge branch 'master' into jep486
>  - ... and 218 more: https://git.openjdk.org/jdk/compare/63eb4853...4535e388

src/java.base/unix/classes/java/lang/ProcessEnvironment.java line 1:

> 1: /*

Why the copyright update? Nothing changed.

src/java.base/windows/classes/java/lang/ProcessImpl.java line 76:

> 74:     {
> 75:         if (append) {
> 76:             String path = f.getPath();

Is the SuppressWarnings annotation still needed on line 71?

src/java.base/windows/classes/java/lang/ProcessImpl.java line 422:

> 420:                         boolean forceNullOutputStream,
> 421:                         final boolean redirectErrorStream)
> 422:         throws IOException

Is the SuppressWarnings annotation still needed on line 415?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22024#discussion_r1838731015
PR Review Comment: https://git.openjdk.org/jdk/pull/22024#discussion_r1838734932
PR Review Comment: https://git.openjdk.org/jdk/pull/22024#discussion_r1838735333