RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v26]
Doug Lea
dl at openjdk.org
Wed Nov 13 13:17:19 UTC 2024
On Wed, 13 Nov 2024 08:55:19 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> Doug Lea has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename variable
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2617:
>
>> 2615: if (q != null)
>> 2616: return q;
>> 2617: if (shutdown != 0L)
>
> @DougLea Any benefit of doing this vs `boolean shutdown = (lockRunState() & SHUTDOWN) != 0L` and check `!shutdown` and `shutdown`
It doesn't seem to matter with respect to generated code. I did it this way for symmetry to other similar usages (including tryTerminate) but for more symmetry should have named it isShutdown, so just changed it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21507#discussion_r1840246733
More information about the core-libs-dev
mailing list