RFR: 8344086: Remove security manager dependency in FFM

Roger Riggs rriggs at openjdk.org
Wed Nov 13 15:28:14 UTC 2024


On Wed, 13 Nov 2024 13:48:14 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes to remove the security manager dependencies in the FFM implementing classes.

lgtm

src/java.base/share/classes/jdk/internal/foreign/SystemLookup.java line 128:

> 126:      */
> 127:     private static Path jdkLibraryPath(String name) {
> 128:         Path javahome = Path.of(System.getProperty("java.home"));

If not out of scope for this PR:
System property java.home is available in a static; will need an `import jdk.internal.util.StaticProperty`
Suggestion:

        Path javahome = StaticProperty.javaHome();

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22071#pullrequestreview-2433591071
PR Review Comment: https://git.openjdk.org/jdk/pull/22071#discussion_r1840583128


More information about the core-libs-dev mailing list