RFR: 8341402: BigDecimal's square root optimization

[fabioromano1]

On Wed, 13 Nov 2024 16:07:42 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>>> Since there's an invocation of `stripTrailingZeros()` anyway, what's the reason to _not_ "optimize" for other round modes as well, like in the current implementation?
>> 
>> Because it is not necessary to strip zeros when an exact result is not requested, so while the call to `stripTrailingZeros()` speeds up only for the unlikely case that the input is an even power of 10, it slows down for all other cases...
>
> @fabioromano1 I took a look at the code, and at first sight it looks good.
> However, before approving, I'll have a deeper look in the next couple of days.

@rgiulietti Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21301#issuecomment-2474064838