RFR: 8341260: Add Float16 to jdk.incubator.vector [v11]

[Jatin Bhateja]

On Wed, 13 Nov 2024 06:40:15 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 91:
>> 
>>> 89: // JEP-401 (https://openjdk.org/jeps/401).
>>> 90: // @jdk.internal.MigratedValueClass
>>> 91: // @jdk.internal.ValueBased
>> 
>> Please uncomment value-based class annotation.
>> Float16 does comply with the semantics of value-based classes.
>> https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/lang/doc-files/ValueBased.html
>
> The jdk.internal.ValueBased annotation is not exported for use outside of the java.base module.

Hi @jddarcy, Would you suggest passing —add-exports=java.base/JDK.internal=ALL-UNNAMED while compiling Float16.java to mark it as a Value-Based class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1841041378