RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v2]

Naman Nigam duke at openjdk.org
Thu Nov 14 03:23:29 UTC 2024


On Thu, 14 Nov 2024 02:36:38 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Naman Nigam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8343125 : Resolve a bad merge
>
> src/java.base/share/classes/java/util/TreeMap.java line 424:
> 
>> 422:     /**
>> 423:      * Returns the entry for the least key greater than or equal to the specified key;
>> 424:      * if no such entry exists (i.e. the specified key is greater than any key in the tree),
> 
> I'd suggest changing "the specified key is greater than any key in the tree" → "the specified key is greater than any key in the tree, or the tree is empty"; same thing for `getFloorEntry()`.

@archiecobbs Thank you for your suggestion. Yes, the tree being an empty case could be made explicit, though I was assuming it to be inferrable by the words 'any key' earlier. Updating with that as a change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21729#discussion_r1841506639


More information about the core-libs-dev mailing list