RFR: 8344179: SecurityManager cleanup in the ZIP and JAR areas

Alan Bateman alanb at openjdk.org
Thu Nov 14 12:23:13 UTC 2024


On Thu, 14 Nov 2024 10:18:18 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this PR which cleans up security manager related code in `java.util.zip` and `java.util.jar`:
> 
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of `GetPropertyAction::privilegedGetProperty`
> *  `ZipFile` is updated to not call SM::checkRead, SM::checkDelete when opening files
> * `ZipOutputStream` is updated to use `Boolean::getBoolean` instead of `GetBooleanAction::privilegedGetProperty`
> 
> The field `ZipFile.startsWithLoc` is deliberately left alone, that should be handled separately. I found no SM-dependent code in the ZIP or JAR tests. 
> 
> Testing: This is a cleanup PR, no tests are changed or updated. ZIP and JAR tests run green locally. GHA results pending.

This looks okay to me. It's likely that others may wish to review this too.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22099#issuecomment-2476215902


More information about the core-libs-dev mailing list