RFR: 8340205: Native linker allows MemoryLayout consisting of only PaddingLayout [v16]
Maurizio Cimadamore
mcimadamore at openjdk.org
Thu Nov 14 12:58:20 UTC 2024
On Wed, 13 Nov 2024 15:21:24 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix failing test
src/java.base/share/classes/java/lang/foreign/Linker.java line 253:
> 251: * <li>{@code L.byteAlignment()} is equal to the sequence layout's <em>natural alignment</em>
> 252: * , and</li>
> 253: * <li>{@code S.elementLayout()} is a well-defined layout.</li>
Suggestion:
* <li>{@code S.elementLayout()} is a well-formed layout.</li>
src/java.base/share/classes/java/lang/foreign/Linker.java line 261:
> 259: * <li>{@code G.byteSize()} is a multiple of {@code G.byteAlignment()}</li>
> 260: * <li>Each member layout in {@code G.memberLayouts()} is either a padding layout or a
> 261: * well-defined layout</li>
Suggestion:
* well-formed layout</li>
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21041#discussion_r1842174338
PR Review Comment: https://git.openjdk.org/jdk/pull/21041#discussion_r1842175387
More information about the core-libs-dev
mailing list