RFR: 8344179: SecurityManager cleanup in the ZIP and JAR areas [v2]
Eirik Bjørsnøs
eirbjo at openjdk.org
Thu Nov 14 13:21:33 UTC 2024
> Please review this PR which cleans up security manager related code in `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of `GetPropertyAction::privilegedGetProperty`
> * `ZipFile` is updated to not call SM::checkRead, SM::checkDelete when opening files
> * `ZipOutputStream` is updated to use `Boolean::getBoolean` instead of `GetBooleanAction::privilegedGetProperty`
>
> The field `ZipFile.startsWithLoc` is deliberately left alone, that should be handled separately. I found no SM-dependent code in the ZIP or JAR tests.
>
> Testing: This is a cleanup PR, no tests are changed or updated. ZIP and JAR tests run green locally. GHA results pending.
Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
Fold lines for System::getProperty when reading enableMultiRelease and inhibitZip64
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22099/files
- new: https://git.openjdk.org/jdk/pull/22099/files/42bee788..6a72b060
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22099&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22099&range=00-01
Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/22099.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22099/head:pull/22099
PR: https://git.openjdk.org/jdk/pull/22099
More information about the core-libs-dev
mailing list