RFR: 8343881: java.lang.classfile.Attribute attributeName() method should return Utf8Entry

[Adam Sotona]

On Thu, 14 Nov 2024 15:35:17 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Class-File API usually expose names in a form of `java.lang.classfile.constantpool.Utf8Entry`. Unfortunately `java.lang.classfile.Attribute::attributeName` method was omitted during the API review and it returns inflated `String` value of the name.
>> 
>> This patch changes return type of `java.lang.classfile.Attribute::attributeName` from `String` to `java.lang.classfile.constantpool.Utf8Entry`.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> src/java.base/share/classes/jdk/internal/classfile/impl/DirectCodeBuilder.java line 445:
> 
>> 443:         @Override
>> 444:         public Utf8Entry attributeName() {
>> 445:             return NAME;
> 
> Maybe `buf.constantPool().utf8Entry(NAME_LINE_NUMBER_TABLE)`?

Good catch, I missed there is buf field initialized.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22107#discussion_r1842448941